feat(embedded): make guest token JWT audience callable or str #18748

lilykuang · 2022-02-15T20:24:30Z

SUMMARY

Allows setting GUEST_TOKEN_JWT_AUDIENCE as a callable, useful for dynamic guest token audience config.
following pattern from feat(reports): SLACK_API_TOKEN as callable or str #13634

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2022-02-15T22:50:46Z

Codecov Report

Merging #18748 (9cb62f1) into master (c8df849) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 9cb62f1 differs from pull request most recent head 61c1a99. Consider uploading reports for the commit 61c1a99 to get more accurate results

@@            Coverage Diff             @@
##           master   #18748      +/-   ##
==========================================
- Coverage   66.31%   66.14%   -0.17%     
==========================================
  Files        1620     1620              
  Lines       63075    63080       +5     
  Branches     6370     6370              
==========================================
- Hits        41827    41725     -102     
- Misses      19591    19698     +107     
  Partials     1657     1657

Flag	Coverage Δ
hive	`?`
mysql	`81.42% <100.00%> (+<0.01%)`	⬆️
postgres	`81.47% <100.00%> (+<0.01%)`	⬆️
presto	`?`
python	`81.55% <100.00%> (-0.35%)`	⬇️
sqlite	`81.15% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/config.py	`91.92% <100.00%> (ø)`
superset/security/manager.py	`94.38% <100.00%> (+0.05%)`	⬆️
superset/db_engines/hive.py	`0.00% <0.00%> (-85.19%)`	⬇️
superset/db_engine_specs/hive.py	`70.27% <0.00%> (-15.45%)`	⬇️
superset/db_engine_specs/presto.py	`83.47% <0.00%> (-5.65%)`	⬇️
superset/connectors/sqla/models.py	`87.33% <0.00%> (-1.44%)`	⬇️
superset/db_engine_specs/base.py	`88.38% <0.00%> (-0.37%)`	⬇️
superset/models/core.py	`88.86% <0.00%> (-0.25%)`	⬇️
superset/utils/core.py	`90.15% <0.00%> (-0.13%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8df849...61c1a99. Read the comment docs.

craig-rueda

LGTM - might be easier to impl as a helper method in the SM

into make-guest-token-audience-callable

apole · 2023-05-15T21:29:33Z

GUEST_TOKEN_JWT_AUDIENCE should be set to the domain name of the application that is embedding Superset or the superset Server?.

feat(embedded): make guest token JWT audience callable

a14c6ff

superset-github-bot bot added the preset-io label Feb 15, 2022

pull-request-size bot added the size/M label Feb 15, 2022

reset GUEST_TOKEN_JWT_AUDIENCE after test

32da50a

lilykuang requested review from suddjian, dpgaspar and craig-rueda February 15, 2022 22:35

craig-rueda approved these changes Feb 15, 2022

View reviewed changes

Lily Kuang added 2 commits February 15, 2022 15:44

helper method for get audience

7563982

Merge branch 'master' of https://github.com/preset-io/incubator-superset

61c1a99

into make-guest-token-audience-callable

lilykuang merged commit b2613f6 into apache:master Feb 16, 2022

lilykuang deleted the make-guest-token-audience-callable branch February 16, 2022 01:47

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(embedded): make guest token JWT audience callable or str #18748

feat(embedded): make guest token JWT audience callable or str #18748

lilykuang commented Feb 15, 2022

codecov bot commented Feb 15, 2022 •

edited

Loading

craig-rueda left a comment

apole commented May 15, 2023

feat(embedded): make guest token JWT audience callable or str #18748

feat(embedded): make guest token JWT audience callable or str #18748

Conversation

lilykuang commented Feb 15, 2022

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Feb 15, 2022 • edited Loading

Codecov Report

craig-rueda left a comment

Choose a reason for hiding this comment

apole commented May 15, 2023

codecov bot commented Feb 15, 2022 •

edited

Loading